Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalBGS cleanup #16412

Closed
wants to merge 19 commits into from
Closed

LocalBGS cleanup #16412

wants to merge 19 commits into from

Conversation

nihil2501
Copy link
Contributor

Move miscellaneous operations out so that:

  • it is easier to look at base-level functionality without all of these various operation implementations intermingled
  • these various operation implementations can eventually be organized according to the standards we've used for other operations

@nihil2501 nihil2501 requested a review from FonzMP April 18, 2024 19:30
@nihil2501 nihil2501 requested a review from a team as a code owner April 18, 2024 19:30
@nihil2501 nihil2501 added the claimsApi modules/claims_api label Apr 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited
Loading

1 Error
🚫 This PR changes 1083 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • config/features.yml (+4/-0)

  • modules/claims_api/README.md (+2/-2)

  • modules/claims_api/app/clients/claims_api/bgs_client.rb (+117/-0)

  • modules/claims_api/app/clients/claims_api/bgs_client/service_action/definition.rb (+28/-0)

  • modules/claims_api/app/clients/claims_api/bgs_client/service_action/external_id.rb (+15/-0)

  • modules/claims_api/app/clients/claims_api/bgs_client/service_action/request.rb (+212/-0)

  • modules/claims_api/app/clients/claims_api/bgs_client/service_action/request/envelope.rb (+75/-0)

  • modules/claims_api/lib/bgs_service/local_bgs.rb (+57/-0)

  • modules/claims_api/lib/bgs_service/local_bgs_refactored.rb (+107/-0)

  • modules/claims_api/lib/bgs_service/local_bgs_refactored/error_handler.rb (+75/-0)

  • modules/claims_api/lib/bgs_service/local_bgs_refactored/miscellaneous.rb (+204/-0)

  • modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/create_veteran_representative_request_spec.rb (+2/-2)

  • modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/read_all_veteran_representatives_spec.rb (+2/-2)

  • modules/claims_api/spec/lib/claims_api/bgs/veteran_representative_service/veteran_representative_service_spec.rb (+0/-1)

  • modules/claims_api/spec/lib/claims_api/local_bgs_refactored_spec.rb (+123/-0)

  • modules/claims_api/spec/lib/claims_api/local_bgs_spec.rb (+8/-0)

  • modules/claims_api/spec/lib/claims_api/manage_representative_service/read_poa_request_spec.rb (+2/-2)

  • modules/claims_api/spec/lib/claims_api/manage_representative_service/update_poa_request_spec.rb (+2/-2)

  • modules/claims_api/spec/lib/claims_api/vnp_atchms_service_spec.rb (+2/-2)

  • modules/claims_api/spec/lib/claims_api/vnp_person_service_spec.rb (+2/-2)

  • modules/claims_api/spec/lib/claims_api/vnp_ptcpnt_addrs_service_spec.rb (+2/-2)

  • modules/claims_api/spec/requests/v2/power_of_attorney_requests/index/rswag_spec.rb (+2/-2)

  • modules/claims_api/spec/support/{bgs_client_helpers.rb => bgs_client_spec_helpers.rb} (+10/-11)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 026d32e to 509dd2f Compare April 18, 2024 19:59
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 19, 2024 10:34 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 509dd2f to 90b193b Compare April 20, 2024 01:34
@nihil2501 nihil2501 requested review from a team as code owners April 20, 2024 01:34
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 20, 2024 01:35 Inactive
@nihil2501 nihil2501 marked this pull request as draft April 20, 2024 01:43
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 20, 2024 01:43 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 499e9e3 to 641202a Compare April 20, 2024 04:53
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 20, 2024 04:54 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 641202a to 81fc530 Compare April 22, 2024 02:54
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 22, 2024 02:55 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 81fc530 to 5c8bec4 Compare April 22, 2024 04:14
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 22, 2024 04:15 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 22, 2024 06:59 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 87855db to 0b85bec Compare April 23, 2024 07:46
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 23, 2024 07:48 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 23, 2024 08:08 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 31bfc18 to 3727fc1 Compare April 23, 2024 08:10
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 23, 2024 08:13 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 3727fc1 to 0ec51f3 Compare April 23, 2024 08:36
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 23, 2024 08:37 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 0ec51f3 to 0c38b02 Compare April 23, 2024 08:45
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 23, 2024 08:46 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 0c38b02 to f61e9d0 Compare April 23, 2024 16:42
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 23, 2024 17:17 Inactive
nihil2501 added 10 commits April 25, 2024 22:53
@nihil2501
extract miscellaneous LocalBGS operations
e8b1d18 
Move miscellaneous operations out so that:
- it is easier to look at base-level functionality without all of these various operation implementations intermingled
- these various operation implementations can eventually be organized according to the standards we've used for other operations
@nihil2501
reorganize LocalBGS
5c4025b 
appease linter in LocalBGS
@nihil2501
unmix miscellaneous LocalBGS operations
bc79bbd 
...and turn it into its own service
@nihil2501
parameterize LocalBGS error handler
a23918a
@nihil2501
BGSClient refactors calling BGS + LocalBGS adapted for compat
8a48216 
- add comments about private access while backwards compat (`LocalBGS`) & intentional (`BGSClient`)
@nihil2501
remix miscellaneous LocalBGS operations
637823f
@nihil2501
extract bgs request envelope generation
a06aa2a
@nihil2501
add bgs service definitions
c98a11e
@nihil2501
Document BGSClient public interface
dfe362f
@nihil2501
preserve conn config variation of LocalBGS in BGSClient
860ea99
@nihil2501 nihil2501 mentioned this pull request Apr 26, 2024
Merged
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from 5dcbe3c to 15f0a3d Compare April 26, 2024 04:57
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 26, 2024 04:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 26, 2024 05:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 26, 2024 05:29 Inactive
@nihil2501 nihil2501 force-pushed the dash/oren/API-34439/local-bgs-cleanup branch from be501aa to 847d3d5 Compare April 26, 2024 09:51
@nihil2501 nihil2501 changed the base branch from master to dash/oren/API-34439/local-bgs-refactor-feature-toggle April 26, 2024 09:54
@va-vfs-bot va-vfs-bot temporarily deployed to dash/oren/API-34439/local-bgs-cleanup/main/main April 26, 2024 10:03 Inactive
Base automatically changed from dash/oren/API-34439/local-bgs-refactor-feature-toggle to master April 26, 2024 17:22
@nihil2501 nihil2501 closed this Apr 26, 2024
@nihil2501 nihil2501 deleted the dash/oren/API-34439/local-bgs-cleanup branch April 26, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FonzMP FonzMP Awaiting requested review from FonzMP

Assignees
No one assigned
Labels
claimsApi modules/claims_api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nihil2501 @va-vfs-bot